]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
net: ep93xx_eth stops receiving packets
authorDavid S. Miller <davem@davemloft.net>
Tue, 4 May 2010 06:21:27 +0000 (23:21 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 4 May 2010 06:21:27 +0000 (23:21 -0700)
Receiving small packet(s) in a fast pace leads to not receiving any
packets at all after some time.

After ethernet packet(s) arrived the receive descriptor is incremented
by the number of frames processed. If another packet arrives while
processing, this is processed in another call of ep93xx_rx. This
second call leads that too many receive descriptors getting released.

This fix increments, even in these case, the right number of processed
receive descriptors.

Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Lennert Buytenhek <buytenh@wantstofly.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/arm/ep93xx_eth.c

index 6995169d285ab10b71ede945c68451d6dc972f21..cd17d09f385cfc60d5e70eb555672e9b0c3b55d6 100644 (file)
@@ -311,11 +311,6 @@ err:
                processed++;
        }
 
-       if (processed) {
-               wrw(ep, REG_RXDENQ, processed);
-               wrw(ep, REG_RXSTSENQ, processed);
-       }
-
        return processed;
 }
 
@@ -350,6 +345,11 @@ poll_some_more:
                        goto poll_some_more;
        }
 
+       if (rx) {
+               wrw(ep, REG_RXDENQ, rx);
+               wrw(ep, REG_RXSTSENQ, rx);
+       }
+
        return rx;
 }