]> bbs.cooldavid.org Git - net-next-2.6.git/commit
drivers/video/matrox/matroxfb_maven.c: fix unsigned return type
authorJulia Lawall <julia@diku.dk>
Wed, 27 Oct 2010 22:33:26 +0000 (15:33 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 28 Oct 2010 01:03:08 +0000 (18:03 -0700)
commit847fb8aca3b79d03ef6c5f87f0843a30ed9e6627
treeb1916b554960b20d4e7e158cfc803f575cc40a1c
parentf0a2f357d46a51f8066eb47b3dba40f87a680804
drivers/video/matrox/matroxfb_maven.c: fix unsigned return type

The function has an unsigned return type, but returns a negative constant
to indicate an error condition.  The result of calling the function is
only tested by comparison to 0, and thus unsigned is not needed and can be
dropped from the return type.

A sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@exists@
identifier f;
constant C;
@@

 unsigned f(...)
 { <+...
*  return -C;
 ...+> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Petr Vandrovec <vandrove@vc.cvut.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/matrox/matroxfb_maven.c