]> bbs.cooldavid.org Git - net-next-2.6.git/commit
i2c: Fix for suspend/resume issue
authorVishwanath BS <vishwanath.bs@ti.com>
Thu, 30 Sep 2010 12:14:22 +0000 (14:14 +0200)
committerJean Delvare <khali@endymion.delvare>
Thu, 30 Sep 2010 12:14:22 +0000 (14:14 +0200)
commit753419f59e10d7181e43f0b9cc5beff43ef3f7a4
tree1655f7b2fe6bd02b21674859b32b32571eb2e42b
parent59bfee6e0682635c269fb271422e2595fa441c21
i2c: Fix for suspend/resume issue

In current i2c core driver, call to pm_runtime_set_active from
i2c_device_pm_resume will unconditionally enable i2c module and
increment child count of the parent. Because of this, in CPU Idle
path, i2c does not idle, preventing Core to enter retention. Also i2c
module will not be suspended upon system suspend as
pm_runtime_set_suspended is not called from i2c_device_pm_suspend.

This issue is fixed by removing pm_runtime_set_active call from resume
path which is not necessary.
This fix has been tested on OMAP4430.

Signed-off-by: Partha Basak <p-basak2@ti.com>
Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/i2c/i2c-core.c