]> bbs.cooldavid.org Git - net-next-2.6.git/commit - net/bridge/br_if.c
git://bbs.cooldavid.org / net-next-2.6.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 8823ad3) | patch
bridge: Fix double-free in br_add_if.
authorJeff Hansen <x@jeffhansen.com>
Mon, 28 Sep 2009 19:54:25 +0000 (12:54 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Sep 2009 19:54:25 +0000 (12:54 -0700)
commit30df94f800368a016d09ee672c9fcc20751d0260
tree1626c98991a1c828d6d359100f5db5bb4e20a946tree | snapshot (tar.bz2 tar.gz zip)
parent8823ad31cd3baf73bd21913cf030b9e7afd22923commit | diff
bridge: Fix double-free in br_add_if.

There is a potential double-kfree in net/bridge/br_if.c.  If br_fdb_insert
fails, then the kobject is put back (which calls kfree due to the kobject
release), and then kfree is called again on the net_bridge_port.  This
patch fixes the crash.

Thanks to Stephen Hemminger for the one-line fix.

Signed-off-by: Jeff Hansen <x@jeffhansen.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_if.c diff | blob | blame | history
Clone of davem's net-next-2.6 tree