]> bbs.cooldavid.org Git - net-next-2.6.git/commit - fs/compat.c
vfs: fix warning: 'dirent' is used uninitialized in this function
authorKevin Winchester <kjwinchester@gmail.com>
Tue, 10 Aug 2010 00:20:22 +0000 (17:20 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 10 Aug 2010 03:45:05 +0000 (20:45 -0700)
commit85c9fe8fcaf630225b26047b3a7cc5167739eced
tree7af001a80ea43c22411f80cd35bd4aceae60e6aa
parentd89b1945b760a6e0e887da004d68432c0bff899a
vfs: fix warning: 'dirent' is used uninitialized in this function

Using:

gcc (GCC) 4.5.0 20100610 (prerelease)

The following warnings appear:

fs/readdir.c: In function `filldir64':
fs/readdir.c:240:15: warning: `dirent' is used uninitialized in this function
fs/readdir.c: In function `filldir':
fs/readdir.c:155:15: warning: `dirent' is used uninitialized in this function
fs/compat.c: In function `compat_filldir64':
fs/compat.c:1071:11: warning: `dirent' is used uninitialized in this function
fs/compat.c: In function `compat_filldir':
fs/compat.c:984:15: warning: `dirent' is used uninitialized in this function

The warnings are related to the use of the NAME_OFFSET() macro.  Luckily,
it appears as though the standard offsetof() macro is what is being
implemented by NAME_OFFSET(), thus we can fix the warning and use a more
standard code construct at the same time.

Signed-off-by: Kevin Winchester <kjwinchester@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/compat.c
fs/readdir.c