]> bbs.cooldavid.org Git - net-next-2.6.git/commit - drivers/net/forcedeth.c
git://bbs.cooldavid.org / net-next-2.6.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: e28e3a6) | patch
fix endian lossage in forcedeth
authorAl Viro <viro@ZenIV.linux.org.uk>
Wed, 26 Mar 2008 05:57:12 +0000 (05:57 +0000)
committerJeff Garzik <jeff@garzik.org>
Fri, 4 Apr 2008 21:26:16 +0000 (17:26 -0400)
commit30ecce908b944079181938e61ddbc00c8b23798c
tree3f19b22d2b9f9aabec197d7d48fcd756df0456batree | snapshot (tar.bz2 tar.gz zip)
parente28e3a614cedb11637f6cc7a30f0812963df62fecommit | diff
fix endian lossage in forcedeth

a) if you initialize something with le32_to_cpu(...), then |= it
with host-endian and feed to cpu_to_le32(), it's most definitely
*not* __le32.  As sparse would've told you...

b) the whole sequence is |= cpu_to_le32(host-endian constant)

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/forcedeth.c diff | blob | blame | history
Clone of davem's net-next-2.6 tree