]> bbs.cooldavid.org Git - net-next-2.6.git/commit - drivers/ide/ide-atapi.c
ide: refactor tf_read() method
authorSergei Shtylyov <sshtylyov@ru.mvista.com>
Wed, 8 Apr 2009 12:13:03 +0000 (14:13 +0200)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Wed, 8 Apr 2009 12:13:03 +0000 (14:13 +0200)
commit3153c26b54230d025c6d536e8d3015def4524906
tree0dc92136480ddfdd2f52a48045446e9ed95ed077
parentc9ff9e7b64138d87023b733e618f29a1d58543f7
ide: refactor tf_read() method

Simplify tf_read() method, making it deal only with 'struct ide_taskfile' and
the validity flags that the upper layer passes, and factoring out the code that
deals with the high order bytes into ide_tf_readback() to be called from the
only two functions interested, ide_complete_cmd() and ide_dump_sector().

This should stop the needless code duplication in this method and so make
it about twice smaller than it was; along with simplifying the setup for
the method call, this should save both time and space...

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/ide-atapi.c
drivers/ide/ide-io-std.c
drivers/ide/ide-io.c
drivers/ide/ide-iops.c
drivers/ide/ide-lib.c
drivers/ide/ide-probe.c
drivers/ide/ide-taskfile.c
drivers/ide/ns87415.c
drivers/ide/scc_pata.c
include/linux/ide.h