]> bbs.cooldavid.org Git - net-next-2.6.git/commit - arch/x86/kernel/apic/io_apic.c
x86: apic: Do not use stacked physid_mask_t
authorCyrill Gorcunov <gorcunov@gmail.com>
Mon, 9 Nov 2009 22:06:59 +0000 (01:06 +0300)
committerIngo Molnar <mingo@elte.hu>
Tue, 10 Nov 2009 04:52:07 +0000 (05:52 +0100)
commit7abc07531383ac7f727cc9d44e1360a829f2082e
treef93b92f86c527cf5d0e12a3b64a7dbcd368fbd95
parentf4a70c55376683213229af7266dc57ad81aee354
x86: apic: Do not use stacked physid_mask_t

We should not use physid_mask_t as a stack based
variable in apic code. This type depends on MAX_APICS
parameter which may be huge enough.

Especially it became a problem with apic NOOP driver which
is portable between 32 bit and 64 bit environment
(where we have really huge MAX_APICS).

So apic driver should operate with pointers and a caller
in turn should aware of allocation physid_mask_t variable.

As a side (but positive) effect -- we may use already
implemented physid_set_mask_of_physid function eliminating
default_apicid_to_cpu_present completely.

Note that physids_coerce and physids_promote turned into static
inline from macro (since macro hides the fact that parameter is
being interpreted as unsigned long, make it explicit).

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Maciej W. Rozycki <macro@linux-mips.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
LKML-Reference: <20091109220659.GA5568@lenovo>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/include/asm/apic.h
arch/x86/include/asm/mpspec.h
arch/x86/kernel/apic/apic_noop.c
arch/x86/kernel/apic/bigsmp_32.c
arch/x86/kernel/apic/es7000_32.c
arch/x86/kernel/apic/io_apic.c
arch/x86/kernel/apic/numaq_32.c
arch/x86/kernel/apic/probe_32.c
arch/x86/kernel/apic/summit_32.c
arch/x86/kernel/visws_quirks.c