[net-next-2.6.git] / tools / perf / util / sort.c

#include "sort.h"
#include "hist.h"

regex_t		parent_regex;
const char	default_parent_pattern[] = "^sys_|^do_page_fault";
const char	*parent_pattern = default_parent_pattern;
const char	default_sort_order[] = "comm,dso,symbol";
const char	*sort_order = default_sort_order;
int		sort__need_collapse = 0;
int		sort__has_parent = 0;

enum sort_type	sort__first_dimension;

char * field_sep;

LIST_HEAD(hist_entry__sort_list);

static int hist_entry__thread_snprintf(struct hist_entry *self, char *bf,
				       size_t size, unsigned int width);
static int hist_entry__comm_snprintf(struct hist_entry *self, char *bf,
				     size_t size, unsigned int width);
static int hist_entry__dso_snprintf(struct hist_entry *self, char *bf,
				    size_t size, unsigned int width);
static int hist_entry__sym_snprintf(struct hist_entry *self, char *bf,
				    size_t size, unsigned int width);
static int hist_entry__parent_snprintf(struct hist_entry *self, char *bf,
				       size_t size, unsigned int width);
static int hist_entry__cpu_snprintf(struct hist_entry *self, char *bf,
				    size_t size, unsigned int width);

struct sort_entry sort_thread = {
	.se_header	= "Command:  Pid",
	.se_cmp		= sort__thread_cmp,
	.se_snprintf	= hist_entry__thread_snprintf,
	.se_width_idx	= HISTC_THREAD,
};

struct sort_entry sort_comm = {
	.se_header	= "Command",
	.se_cmp		= sort__comm_cmp,
	.se_collapse	= sort__comm_collapse,
	.se_snprintf	= hist_entry__comm_snprintf,
	.se_width_idx	= HISTC_COMM,
};

struct sort_entry sort_dso = {
	.se_header	= "Shared Object",
	.se_cmp		= sort__dso_cmp,
	.se_snprintf	= hist_entry__dso_snprintf,
	.se_width_idx	= HISTC_DSO,
};

struct sort_entry sort_sym = {
	.se_header	= "Symbol",
	.se_cmp		= sort__sym_cmp,
	.se_snprintf	= hist_entry__sym_snprintf,
	.se_width_idx	= HISTC_SYMBOL,
};

struct sort_entry sort_parent = {
	.se_header	= "Parent symbol",
	.se_cmp		= sort__parent_cmp,
	.se_snprintf	= hist_entry__parent_snprintf,
	.se_width_idx	= HISTC_PARENT,
};
 
struct sort_entry sort_cpu = {
	.se_header      = "CPU",
	.se_cmp	        = sort__cpu_cmp,
	.se_snprintf    = hist_entry__cpu_snprintf,
	.se_width_idx	= HISTC_CPU,
};

struct sort_dimension {
	const char		*name;
	struct sort_entry	*entry;
	int			taken;
};

static struct sort_dimension sort_dimensions[] = {
	{ .name = "pid",	.entry = &sort_thread,	},
	{ .name = "comm",	.entry = &sort_comm,	},
	{ .name = "dso",	.entry = &sort_dso,	},
	{ .name = "symbol",	.entry = &sort_sym,	},
	{ .name = "parent",	.entry = &sort_parent,	},
	{ .name = "cpu",	.entry = &sort_cpu,	},
};

int64_t cmp_null(void *l, void *r)
{
	if (!l && !r)
		return 0;
	else if (!l)
		return -1;
	else
		return 1;
}

/* --sort pid */

int64_t
sort__thread_cmp(struct hist_entry *left, struct hist_entry *right)
{
	return right->thread->pid - left->thread->pid;
}

static int repsep_snprintf(char *bf, size_t size, const char *fmt, ...)
{
	int n;
	va_list ap;

	va_start(ap, fmt);
	n = vsnprintf(bf, size, fmt, ap);
	if (field_sep && n > 0) {
		char *sep = bf;

		while (1) {
			sep = strchr(sep, *field_sep);
			if (sep == NULL)
				break;
			*sep = '.';
		}
	}
	va_end(ap);
	return n;
}

static int hist_entry__thread_snprintf(struct hist_entry *self, char *bf,
				       size_t size, unsigned int width)
{
	return repsep_snprintf(bf, size, "%*s:%5d", width,
			      self->thread->comm ?: "", self->thread->pid);
}

static int hist_entry__comm_snprintf(struct hist_entry *self, char *bf,
				     size_t size, unsigned int width)
{
	return repsep_snprintf(bf, size, "%*s", width, self->thread->comm);
}

/* --sort dso */

int64_t
sort__dso_cmp(struct hist_entry *left, struct hist_entry *right)
{
	struct dso *dso_l = left->ms.map ? left->ms.map->dso : NULL;
	struct dso *dso_r = right->ms.map ? right->ms.map->dso : NULL;
	const char *dso_name_l, *dso_name_r;

	if (!dso_l || !dso_r)
		return cmp_null(dso_l, dso_r);

	if (verbose) {
		dso_name_l = dso_l->long_name;
		dso_name_r = dso_r->long_name;
	} else {
		dso_name_l = dso_l->short_name;
		dso_name_r = dso_r->short_name;
	}

	return strcmp(dso_name_l, dso_name_r);
}

static int hist_entry__dso_snprintf(struct hist_entry *self, char *bf,
				    size_t size, unsigned int width)
{
	if (self->ms.map && self->ms.map->dso) {
		const char *dso_name = !verbose ? self->ms.map->dso->short_name :
						  self->ms.map->dso->long_name;
		return repsep_snprintf(bf, size, "%-*s", width, dso_name);
	}

	return repsep_snprintf(bf, size, "%*Lx", width, self->ip);
}

/* --sort symbol */

int64_t
sort__sym_cmp(struct hist_entry *left, struct hist_entry *right)
{
	u64 ip_l, ip_r;

	if (left->ms.sym == right->ms.sym)
		return 0;

	ip_l = left->ms.sym ? left->ms.sym->start : left->ip;
	ip_r = right->ms.sym ? right->ms.sym->start : right->ip;

	return (int64_t)(ip_r - ip_l);
}

static int hist_entry__sym_snprintf(struct hist_entry *self, char *bf,
				    size_t size, unsigned int width __used)
{
	size_t ret = 0;

	if (verbose) {
		char o = self->ms.map ? dso__symtab_origin(self->ms.map->dso) : '!';
		ret += repsep_snprintf(bf, size, "%*Lx %c ",
				       BITS_PER_LONG / 4, self->ip, o);
	}

	ret += repsep_snprintf(bf + ret, size - ret, "[%c] ", self->level);
	if (self->ms.sym)
		ret += repsep_snprintf(bf + ret, size - ret, "%s",
				       self->ms.sym->name);
	else
		ret += repsep_snprintf(bf + ret, size - ret, "%*Lx",
				       BITS_PER_LONG / 4, self->ip);

	return ret;
}

/* --sort comm */

int64_t
sort__comm_cmp(struct hist_entry *left, struct hist_entry *right)
{
	return right->thread->pid - left->thread->pid;
}

int64_t
sort__comm_collapse(struct hist_entry *left, struct hist_entry *right)
{
	char *comm_l = left->thread->comm;
	char *comm_r = right->thread->comm;

	if (!comm_l || !comm_r)
		return cmp_null(comm_l, comm_r);

	return strcmp(comm_l, comm_r);
}

/* --sort parent */

int64_t
sort__parent_cmp(struct hist_entry *left, struct hist_entry *right)
{
	struct symbol *sym_l = left->parent;
	struct symbol *sym_r = right->parent;

	if (!sym_l || !sym_r)
		return cmp_null(sym_l, sym_r);

	return strcmp(sym_l->name, sym_r->name);
}

static int hist_entry__parent_snprintf(struct hist_entry *self, char *bf,
				       size_t size, unsigned int width)
{
	return repsep_snprintf(bf, size, "%-*s", width,
			      self->parent ? self->parent->name : "[other]");
}

/* --sort cpu */

int64_t
sort__cpu_cmp(struct hist_entry *left, struct hist_entry *right)
{
	return right->cpu - left->cpu;
}

static int hist_entry__cpu_snprintf(struct hist_entry *self, char *bf,
				       size_t size, unsigned int width)
{
	return repsep_snprintf(bf, size, "%-*d", width, self->cpu);
}

int sort_dimension__add(const char *tok)
{
	unsigned int i;

	for (i = 0; i < ARRAY_SIZE(sort_dimensions); i++) {
		struct sort_dimension *sd = &sort_dimensions[i];

		if (sd->taken)
			continue;

		if (strncasecmp(tok, sd->name, strlen(tok)))
			continue;

		if (sd->entry->se_collapse)
			sort__need_collapse = 1;

		if (sd->entry == &sort_parent) {
			int ret = regcomp(&parent_regex, parent_pattern, REG_EXTENDED);
			if (ret) {
				char err[BUFSIZ];

				regerror(ret, &parent_regex, err, sizeof(err));
				pr_err("Invalid regex: %s\n%s", parent_pattern, err);
				return -EINVAL;
			}
			sort__has_parent = 1;
		}

		if (list_empty(&hist_entry__sort_list)) {
			if (!strcmp(sd->name, "pid"))
				sort__first_dimension = SORT_PID;
			else if (!strcmp(sd->name, "comm"))
				sort__first_dimension = SORT_COMM;
			else if (!strcmp(sd->name, "dso"))
				sort__first_dimension = SORT_DSO;
			else if (!strcmp(sd->name, "symbol"))
				sort__first_dimension = SORT_SYM;
			else if (!strcmp(sd->name, "parent"))
				sort__first_dimension = SORT_PARENT;
			else if (!strcmp(sd->name, "cpu"))
				sort__first_dimension = SORT_CPU;
		}

		list_add_tail(&sd->entry->list, &hist_entry__sort_list);
		sd->taken = 1;

		return 0;
	}

	return -ESRCH;
}

void setup_sorting(const char * const usagestr[], const struct option *opts)
{
	char *tmp, *tok, *str = strdup(sort_order);

	for (tok = strtok_r(str, ", ", &tmp);
			tok; tok = strtok_r(NULL, ", ", &tmp)) {
		if (sort_dimension__add(tok) < 0) {
			error("Unknown --sort key: `%s'", tok);
			usage_with_options(usagestr, opts);
		}
	}

	free(str);
}

void sort_entry__setup_elide(struct sort_entry *self, struct strlist *list,
			     const char *list_name, FILE *fp)
{
	if (list && strlist__nr_entries(list) == 1) {
		if (fp != NULL)
			fprintf(fp, "# %s: %s\n", list_name,
				strlist__entry(list, 0)->s);
		self->elide = true;
	}
}
Commit	Line	Data
dd68ada2	1	#include "sort.h"
8a6c5b26	2	#include "hist.h"
dd68ada2 JK	3
dd68ada2 JK	4	regex_t parent_regex;
edb7c60e ACM	5	const char default_parent_pattern[] = "^sys_\|^do_page_fault";
	6	const char *parent_pattern = default_parent_pattern;
	7	const char default_sort_order[] = "comm,dso,symbol";
	8	const char *sort_order = default_sort_order;
af0a6fa4 FW	9	int sort__need_collapse = 0;
af0a6fa4 FW	10	int sort__has_parent = 0;
a4fb581b FW	11
a4fb581b FW	12	enum sort_type sort__first_dimension;
dd68ada2	13
dd68ada2 JK	14	char * field_sep;
	15
	16	LIST_HEAD(hist_entry__sort_list);
	17
a4e3b956 ACM	18	static int hist_entry__thread_snprintf(struct hist_entry self, char bf,
	19	size_t size, unsigned int width);
	20	static int hist_entry__comm_snprintf(struct hist_entry self, char bf,
	21	size_t size, unsigned int width);
	22	static int hist_entry__dso_snprintf(struct hist_entry self, char bf,
	23	size_t size, unsigned int width);
	24	static int hist_entry__sym_snprintf(struct hist_entry self, char bf,
	25	size_t size, unsigned int width);
	26	static int hist_entry__parent_snprintf(struct hist_entry self, char bf,
	27	size_t size, unsigned int width);
f60f3593 AS	28	static int hist_entry__cpu_snprintf(struct hist_entry self, char bf,
f60f3593 AS	29	size_t size, unsigned int width);
a4e3b956	30
dd68ada2	31	struct sort_entry sort_thread = {
fcd14984 FW	32	.se_header = "Command: Pid",
	33	.se_cmp = sort__thread_cmp,
	34	.se_snprintf = hist_entry__thread_snprintf,
8a6c5b26	35	.se_width_idx = HISTC_THREAD,
dd68ada2 JK	36	};
	37
	38	struct sort_entry sort_comm = {
fcd14984 FW	39	.se_header = "Command",
	40	.se_cmp = sort__comm_cmp,
	41	.se_collapse = sort__comm_collapse,
	42	.se_snprintf = hist_entry__comm_snprintf,
8a6c5b26	43	.se_width_idx = HISTC_COMM,
dd68ada2 JK	44	};
	45
	46	struct sort_entry sort_dso = {
fcd14984 FW	47	.se_header = "Shared Object",
	48	.se_cmp = sort__dso_cmp,
	49	.se_snprintf = hist_entry__dso_snprintf,
8a6c5b26	50	.se_width_idx = HISTC_DSO,
dd68ada2 JK	51	};
	52
	53	struct sort_entry sort_sym = {
fcd14984 FW	54	.se_header = "Symbol",
	55	.se_cmp = sort__sym_cmp,
	56	.se_snprintf = hist_entry__sym_snprintf,
8a6c5b26	57	.se_width_idx = HISTC_SYMBOL,
dd68ada2 JK	58	};
	59
	60	struct sort_entry sort_parent = {
fcd14984 FW	61	.se_header = "Parent symbol",
	62	.se_cmp = sort__parent_cmp,
	63	.se_snprintf = hist_entry__parent_snprintf,
8a6c5b26	64	.se_width_idx = HISTC_PARENT,
dd68ada2	65	};
f60f3593 AS	66
	67	struct sort_entry sort_cpu = {
	68	.se_header = "CPU",
	69	.se_cmp = sort__cpu_cmp,
	70	.se_snprintf = hist_entry__cpu_snprintf,
8a6c5b26	71	.se_width_idx = HISTC_CPU,
f60f3593	72	};
dd68ada2 JK	73
	74	struct sort_dimension {
	75	const char *name;
	76	struct sort_entry *entry;
	77	int taken;
	78	};
	79
	80	static struct sort_dimension sort_dimensions[] = {
	81	{ .name = "pid", .entry = &sort_thread, },
	82	{ .name = "comm", .entry = &sort_comm, },
	83	{ .name = "dso", .entry = &sort_dso, },
	84	{ .name = "symbol", .entry = &sort_sym, },
	85	{ .name = "parent", .entry = &sort_parent, },
f60f3593	86	{ .name = "cpu", .entry = &sort_cpu, },
dd68ada2 JK	87	};
	88
	89	int64_t cmp_null(void l, void r)
	90	{
	91	if (!l && !r)
	92	return 0;
	93	else if (!l)
	94	return -1;
	95	else
	96	return 1;
	97	}
	98
	99	/* --sort pid */
	100
	101	int64_t
	102	sort__thread_cmp(struct hist_entry left, struct hist_entry right)
	103	{
	104	return right->thread->pid - left->thread->pid;
	105	}
	106
a4e3b956	107	static int repsep_snprintf(char bf, size_t size, const char fmt, ...)
dd68ada2 JK	108	{
	109	int n;
	110	va_list ap;
	111
	112	va_start(ap, fmt);
a4e3b956 ACM	113	n = vsnprintf(bf, size, fmt, ap);
	114	if (field_sep && n > 0) {
	115	char *sep = bf;
	116
	117	while (1) {
	118	sep = strchr(sep, *field_sep);
	119	if (sep == NULL)
	120	break;
	121	*sep = '.';
dd68ada2	122	}
dd68ada2 JK	123	}
	124	va_end(ap);
	125	return n;
	126	}
	127
a4e3b956 ACM	128	static int hist_entry__thread_snprintf(struct hist_entry self, char bf,
a4e3b956 ACM	129	size_t size, unsigned int width)
dd68ada2	130	{
a4e3b956	131	return repsep_snprintf(bf, size, "%*s:%5d", width,
dd68ada2 JK	132	self->thread->comm ?: "", self->thread->pid);
	133	}
	134
a4e3b956 ACM	135	static int hist_entry__comm_snprintf(struct hist_entry self, char bf,
a4e3b956 ACM	136	size_t size, unsigned int width)
dd68ada2	137	{
a4e3b956	138	return repsep_snprintf(bf, size, "%*s", width, self->thread->comm);
dd68ada2 JK	139	}
	140
	141	/* --sort dso */
	142
	143	int64_t
	144	sort__dso_cmp(struct hist_entry left, struct hist_entry right)
	145	{
59fd5306 ACM	146	struct dso *dso_l = left->ms.map ? left->ms.map->dso : NULL;
59fd5306 ACM	147	struct dso *dso_r = right->ms.map ? right->ms.map->dso : NULL;
439d473b	148	const char dso_name_l, dso_name_r;
dd68ada2 JK	149
	150	if (!dso_l \|\| !dso_r)
	151	return cmp_null(dso_l, dso_r);
	152
439d473b ACM	153	if (verbose) {
	154	dso_name_l = dso_l->long_name;
	155	dso_name_r = dso_r->long_name;
	156	} else {
	157	dso_name_l = dso_l->short_name;
	158	dso_name_r = dso_r->short_name;
	159	}
	160
	161	return strcmp(dso_name_l, dso_name_r);
dd68ada2 JK	162	}
dd68ada2 JK	163
a4e3b956 ACM	164	static int hist_entry__dso_snprintf(struct hist_entry self, char bf,
a4e3b956 ACM	165	size_t size, unsigned int width)
dd68ada2	166	{
59fd5306 ACM	167	if (self->ms.map && self->ms.map->dso) {
	168	const char *dso_name = !verbose ? self->ms.map->dso->short_name :
	169	self->ms.map->dso->long_name;
a4e3b956	170	return repsep_snprintf(bf, size, "%-*s", width, dso_name);
439d473b	171	}
dd68ada2	172
a4e3b956	173	return repsep_snprintf(bf, size, "%*Lx", width, self->ip);
dd68ada2 JK	174	}
	175
	176	/* --sort symbol */
	177
	178	int64_t
	179	sort__sym_cmp(struct hist_entry left, struct hist_entry right)
	180	{
	181	u64 ip_l, ip_r;
	182
59fd5306	183	if (left->ms.sym == right->ms.sym)
dd68ada2 JK	184	return 0;
dd68ada2 JK	185
59fd5306 ACM	186	ip_l = left->ms.sym ? left->ms.sym->start : left->ip;
59fd5306 ACM	187	ip_r = right->ms.sym ? right->ms.sym->start : right->ip;
dd68ada2 JK	188
	189	return (int64_t)(ip_r - ip_l);
	190	}
	191
a4e3b956 ACM	192	static int hist_entry__sym_snprintf(struct hist_entry self, char bf,
a4e3b956 ACM	193	size_t size, unsigned int width __used)
dd68ada2 JK	194	{
	195	size_t ret = 0;
	196
439d473b	197	if (verbose) {
59fd5306	198	char o = self->ms.map ? dso__symtab_origin(self->ms.map->dso) : '!';
fb89941e ACM	199	ret += repsep_snprintf(bf, size, "%*Lx %c ",
fb89941e ACM	200	BITS_PER_LONG / 4, self->ip, o);
439d473b	201	}
dd68ada2	202
a4e3b956	203	ret += repsep_snprintf(bf + ret, size - ret, "[%c] ", self->level);
59fd5306	204	if (self->ms.sym)
a4e3b956 ACM	205	ret += repsep_snprintf(bf + ret, size - ret, "%s",
a4e3b956 ACM	206	self->ms.sym->name);
439d473b	207	else
fb89941e ACM	208	ret += repsep_snprintf(bf + ret, size - ret, "%*Lx",
fb89941e ACM	209	BITS_PER_LONG / 4, self->ip);
dd68ada2 JK	210
	211	return ret;
	212	}
	213
	214	/* --sort comm */
	215
	216	int64_t
	217	sort__comm_cmp(struct hist_entry left, struct hist_entry right)
	218	{
	219	return right->thread->pid - left->thread->pid;
	220	}
	221
	222	int64_t
	223	sort__comm_collapse(struct hist_entry left, struct hist_entry right)
	224	{
	225	char *comm_l = left->thread->comm;
	226	char *comm_r = right->thread->comm;
	227
	228	if (!comm_l \|\| !comm_r)
	229	return cmp_null(comm_l, comm_r);
	230
	231	return strcmp(comm_l, comm_r);
	232	}
	233
	234	/* --sort parent */
	235
	236	int64_t
	237	sort__parent_cmp(struct hist_entry left, struct hist_entry right)
	238	{
	239	struct symbol *sym_l = left->parent;
	240	struct symbol *sym_r = right->parent;
	241
	242	if (!sym_l \|\| !sym_r)
	243	return cmp_null(sym_l, sym_r);
	244
	245	return strcmp(sym_l->name, sym_r->name);
	246	}
	247
a4e3b956 ACM	248	static int hist_entry__parent_snprintf(struct hist_entry self, char bf,
a4e3b956 ACM	249	size_t size, unsigned int width)
dd68ada2	250	{
a4e3b956	251	return repsep_snprintf(bf, size, "%-*s", width,
dd68ada2 JK	252	self->parent ? self->parent->name : "[other]");
	253	}
	254
f60f3593 AS	255	/* --sort cpu */
	256
	257	int64_t
	258	sort__cpu_cmp(struct hist_entry left, struct hist_entry right)
	259	{
	260	return right->cpu - left->cpu;
	261	}
	262
	263	static int hist_entry__cpu_snprintf(struct hist_entry self, char bf,
	264	size_t size, unsigned int width)
	265	{
	266	return repsep_snprintf(bf, size, "%-*d", width, self->cpu);
	267	}
	268
dd68ada2 JK	269	int sort_dimension__add(const char *tok)
	270	{
	271	unsigned int i;
	272
	273	for (i = 0; i < ARRAY_SIZE(sort_dimensions); i++) {
	274	struct sort_dimension *sd = &sort_dimensions[i];
	275
	276	if (sd->taken)
	277	continue;
	278
	279	if (strncasecmp(tok, sd->name, strlen(tok)))
	280	continue;
	281
fcd14984	282	if (sd->entry->se_collapse)
dd68ada2 JK	283	sort__need_collapse = 1;
	284
	285	if (sd->entry == &sort_parent) {
	286	int ret = regcomp(&parent_regex, parent_pattern, REG_EXTENDED);
	287	if (ret) {
	288	char err[BUFSIZ];
	289
	290	regerror(ret, &parent_regex, err, sizeof(err));
2aefa4f7 ACM	291	pr_err("Invalid regex: %s\n%s", parent_pattern, err);
2aefa4f7 ACM	292	return -EINVAL;
dd68ada2 JK	293	}
	294	sort__has_parent = 1;
	295	}
	296
a4fb581b FW	297	if (list_empty(&hist_entry__sort_list)) {
	298	if (!strcmp(sd->name, "pid"))
	299	sort__first_dimension = SORT_PID;
	300	else if (!strcmp(sd->name, "comm"))
	301	sort__first_dimension = SORT_COMM;
	302	else if (!strcmp(sd->name, "dso"))
	303	sort__first_dimension = SORT_DSO;
	304	else if (!strcmp(sd->name, "symbol"))
	305	sort__first_dimension = SORT_SYM;
	306	else if (!strcmp(sd->name, "parent"))
	307	sort__first_dimension = SORT_PARENT;
f60f3593 AS	308	else if (!strcmp(sd->name, "cpu"))
f60f3593 AS	309	sort__first_dimension = SORT_CPU;
a4fb581b	310	}
af0a6fa4	311
dd68ada2 JK	312	list_add_tail(&sd->entry->list, &hist_entry__sort_list);
	313	sd->taken = 1;
	314
	315	return 0;
	316	}
	317
	318	return -ESRCH;
	319	}
c8829c7a ACM	320
	321	void setup_sorting(const char * const usagestr[], const struct option *opts)
	322	{
	323	char tmp, tok, *str = strdup(sort_order);
	324
	325	for (tok = strtok_r(str, ", ", &tmp);
	326	tok; tok = strtok_r(NULL, ", ", &tmp)) {
	327	if (sort_dimension__add(tok) < 0) {
	328	error("Unknown --sort key: `%s'", tok);
	329	usage_with_options(usagestr, opts);
	330	}
	331	}
	332
	333	free(str);
	334	}
c351c281 ACM	335
	336	void sort_entry__setup_elide(struct sort_entry self, struct strlist list,
	337	const char list_name, FILE fp)
	338	{
	339	if (list && strlist__nr_entries(list) == 1) {
	340	if (fp != NULL)
	341	fprintf(fp, "# %s: %s\n", list_name,
	342	strlist__entry(list, 0)->s);
	343	self->elide = true;
	344	}
	345	}